This looks correct to me. I suspected SGI got lost when I develop root cell suspend/resume. And your changes indeed address the issue.
Johan Carlsson <[email protected]> 于2023年3月31日周五 20:25写道： > Hi, I'm sending SGI interrupts between cores with a gic-v3 and noticed > that it sometimes the interrupts were lost. After some tinkering I realised > that gicv3_inject_irq skips the interrupt if it is already in a the list. > I'm not sure this is correct but I expect that the if it is already in the > list but marked as active the pending bit should be set and return. > > With the following change no SGI interrupt where dropped. > > --- a/hypervisor/arch/arm-common/gic-v3.c > +++ b/hypervisor/arch/arm-common/gic-v3.c > @@ -566,8 +566,16 @@ static int gicv3_inject_irq(u16 irq_id, u16 sender) > * A strict phys->virt id mapping is used for SPIs, so > this test > * should be sufficient. > */ > - if ((u32)lr == irq_id) > + if ((u32)lr == irq_id) { > + /* if interrupt is active set pending bit. */ > + if ((lr & ICH_LR_PENDACTIVE) == ICH_LR_ACTIVE) { > + lr |= ICH_LR_GROUP_BIT; > + lr |= ICH_LR_PENDING; > + gicv3_write_lr(n, lr); > + return 0; > + } > return -EEXIST; > + } > } > > Feel free to add my: Tested-by: Peng Fan <[email protected]> if you do a formal patch. > -- > You received this message because you are subscribed to the Google Groups > "Jailhouse" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jailhouse-dev/596f9ab5-8817-4ddb-8c0b-8d1dfbfd8007n%40googlegroups.com > <https://groups.google.com/d/msgid/jailhouse-dev/596f9ab5-8817-4ddb-8c0b-8d1dfbfd8007n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/CAEfxd--FGSJMkPhD1fds11Gh_DBMQGZiabAyVQ1QYEqcs112mg%40mail.gmail.com.
