Hi David
Thanks for your feedback - I was never a real Smalltalker - I've only ever
tinkered with it.
From: "David Rees" <[EMAIL PROTECTED]>
> Actually, I see that you did implement iterators as well (nice). I
> would have expected you to leverage them in the CollectionUtils
> methods. Perhaps you wanted to avoid the extra iterator instantiation?
Yes.
> FYI, I found a couple of small (but important ;) bugs in a casual
> comparison to my implementation:
Cool! Thank you!
> FilterIterator.next() seems to assume hasNext() is always called
> before it.
I'll look into that one - well spotted.
> FilterIterator().remove() could delete the wrong item if its called
> after a hasNext().
I'll fix that one too.
> As a final thought, to be closer to Smalltalk (if you care) "find"
> becomes "detect" and "forAllDo" is just "do".
I'll try fix all these issues before I check the code into CVS this weekend.
Thanks Dave
James
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
