> > BTW I don't really like the prefix 'temp_', smells too much to > > 'temporary'. What about changing it to 'thermo_'? > > > The TC77 *only* measures temperature, nothing else. Besides, the "celsius" > part says something about the temperature too. >
IIRC, even if I have sufgested to prefix with "temp_", I have to admit it can be confusing... Yes, the procedure's name give clues about something related to temperature, but the filename itself is confusing: temp_tc77.jal... > The CO2 library has similar deviations from our naming conventions (no > CO2-prefix for global variables/constants and procedures/functions). > > I can rename them to device_function() too. Trouble is, the library name is > function_device.jal. As in lcd_hd444780.jal > The lib (filename) is named: co2_t6603.jal. function = co2, device = t6603. Following our convention, instead of having "get_co2_status", you should have t6603_get_status() or t6603_get_co2_status(). So when a new lib wil deal with co2, there won't be any namespace collision. Except if you want to be able to have a common interface, so you just have to substitute the "include" statement, and all procedures/functions remain the same. Err... Isn't this complicated ? Isn't this a bad sign ?... > > Seb, speak. > blablablabla... :) > Can you define a namespace for: > I can suggest... > > library files > function_device > library procedures > library variables > variables and procedures follow the same rules, no distinction. For both: device_whatever if you want to avoid namespace collision or function_whatever if you want to have a common API between different libs, in order to only substitute the implementation. device specific vars/pins > These are defined in Rob's device file use guide, right ? > > where we have the function (lcd, co2, temperature) and the device (HD44780, > T6603, TC77). > > Some more nitpicking: > Of the pic_data_eeprom library the 'pic_' prefix should be removed from > its name. > > I agree. > OK, I'll remove "pic_" prefix. > > The data_eeprom, adc, pwm, serial_hardware, serial_software libs have > not the 3-byte indent. > > ??? indentation by bytes? > Well, technically speaking, a space char can be coded on one byte :) > > Several samples have also not the 3 char indent. > > These should be fixed before release. > > Seb, do you have a script to compile all samples? Some are not updated > after changes in the libraries and it would be useful as last minute check. > > The jalib python script can handle multiple arguments. > For validation, not for compilation. Seb --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
