On 8 Oct 2008, at 15:09 , Rob Hamerling wrote: > I have given my vote for beta1. I hesitated with libraries which I > have > not actually used. For the moment I left most of these blank. Me too.
Two blink files refused to burn, I gave them a -1. > I noticed that only votes for the libraries were brought out, not for > the blink and other samples. Maybe we don't need to vote, why not > make > all samples part of the beta1 (like all device files)? > > I was about to vote for the temp_tc77 library. I have used the TC77 in > the past and also some similar chips like the LM74 (but not with JAL), > so I was interested. > While looking at the source I noticed some 'irregularities': > - some global variables (SIO and SCK) are in upper case and without > prefix temp_ They are called that way in the datasheet. SIO is not used in PIC datasheets. SCK is! Both are not likely be used as variables, but might. Yes, TC77_SIO would be better. I can rename them to TC77_SIO and TC77_SCK. Convention is to name chip-specific vars/pins uppercase. They are not used outside the lib. /CS is. > - delay_1ms is called without '()' fixed > - the read_ procedures do not start with temp_ they are named device_function() > BTW I don't really like the prefix 'temp_', smells too much to > 'temporary'. What about changing it to 'thermo_'? The TC77 *only* measures temperature, nothing else. Besides, the "celsius" part says something about the temperature too. > The CO2 library has similar deviations from our naming conventions (no > CO2-prefix for global variables/constants and procedures/functions). I can rename them to device_function() too. Trouble is, the library name is function_device.jal. As in lcd_hd444780.jal Seb, speak. Can you define a namespace for: library files library procedures library variables device specific vars/pins where we have the function (lcd, co2, temperature) and the device (HD44780, T6603, TC77). > Some more nitpicking: > Of the pic_data_eeprom library the 'pic_' prefix should be removed > from > its name. I agree. > The data_eeprom, adc, pwm, serial_hardware, serial_software libs have > not the 3-byte indent. ??? indentation by bytes? > Several samples have also not the 3 char indent. > > These should be fixed before release. > > Seb, do you have a script to compile all samples? Some are not updated > after changes in the libraries and it would be useful as last > minute check. The jalib python script can handle multiple arguments. > > > > Regards, Rob. > > -- > Rob Hamerling, Vianen, NL (http://www.robh.nl/) > > > --- ir EE van Andel [EMAIL PROTECTED] http://www.fiwihex.nl Fiwihex B.V. Wierdensestraat 74, NL7604BK Almelo, Netherlands tel+31-546-491106 fax+31-546-491107 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
