Hi Rob,

Indeed this lib needs refactoring, and maybe even rewrite. This is issue 58
(http://code.google.com/p/jallib/issues/detail?id=58). I don't have much
experience in ADC too, but I could give a try. This will take time though...
This is quite a big piece of code, quite complex too.

Can you remind me what ADC_GROUP is, and how it would help us ?

Have you been able to identify the problem for 16f690 ? BTW, could you reply
to Carlo about your test ?


Cheers,
Seb



>
> Hi Seb and others,
>
> I saw on Jallist a discussion about ADC for a 16F690.
> I have a Pickit2 and Low PinCount demo board with 16F690 and did a quick
> try by modifying the sample for the 16F88. It seems not to work....
>
> I had a look in the ADC library and saw some limitations. I didn't check
> for many PICs, but it looks like it will not work without changes for
> the 16F690. For example the ADC lib doesn't take care of ANSEL, and
> after enable_digital_io() all pins are digital!
>
> I think this lib needs quite some refactoring to make it more of general
> use!  One of the things we may have to do is declare ADC_group as
> constant in the device files (it is currently only a comment).
>
> I have not much experience with ADC, and my priority for ADC is low. So
> is there  another volunteer here?
>
> Regards, Rob.
>
>
> --
> Rob Hamerling, Vianen, NL (http://www.robh.nl/)
>
> >
>


-- 
Sébastien Lelong
http://www.sirloon.net
http://sirbot.org

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to