Hi Vasile,
On 2011/01/13 14:36, vasile surducan wrote:
I've detected a mismatch of the register name in PC18F46J11 and probably other. SSP1CON1 is named SSP1CON. Not a real problem util trying to use i2c_hardware library with I2C1 or with I2C2 when I2C definition must be changed. This is creating confusions. I think Microchip names should be kept.
I understand your arguments, but this 'normalisation' was done to cleanup the mess created by Microchip in register namings for the different PICs. There may be a good reason to change the normalisation, but it will probably have great influence on libraries and possibly (sample) programs. So it has to be discussed/reviewed carefully. The structured way we do this is by opening an issue: collect arguments, discuss these and try to agree about a redesign. You are kindly invited to open an issue!
Some other lines must be added for i2c1 initialization routine as:
You might open a separate issue for this, since it concerns a different set of libs (and authors).
Regards, Rob. -- R. Hamerling, Netherlands --- http://www.robh.nl -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
