Hi Brian, Impressive piece of work! And indeed, well done in the style of jallib. Only a few (nitpicking) issues: - ;@jallib tags are used in test_ and board_ files to create samples. No point in using them in hand-created samples. - There is something odd on the 'Notes:' tag - the validation program complaints about it but I am not sure why. But maybe Seb can tell us. - I wonder if rtc_read() shouldn't be considered an internal procedure and thus start with an underscore. - I think it is good to add more comment to the sample file. The use of pseudo vars makes setup of the clock look so simple, that I had to look at it twice (or mybe even 4 times ;) before I understood how powerfull this is. Like: rtc_hours = 16 -- trigger i2c comms with rtc_bq32000 to set hours to 16.
Thinking about this: how do you make sure the independent reading/setting of vars results in a consistent set of date? E.g. at 13:59, you read the hours (13) and before you can read the minutes, the clock is incremented to 14:00 so you read 00 with 13:00 as a result. Not an issue when you continues put it on screen. But when you use it for logging or - worse - while setting the clock.... Having said this, I want to repeat it is an impressive piece of work. Well done! Joep. 2011/1/24 Brian Edmonson <[email protected]>: > Oh, I almost forgot. Here's a screen shot of the output from the sample > program. > > Regards, > > -Brian E. > > Attachments: rtc_sample_output.jpg > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
