But what would be the benefits ? Seb
2011/4/3 mattschinkel <[email protected]> > If nobody objects, I would like to make the following change... > > in usb_ep_data_out_callback(....,word in buffer_addr,......), we > currently have the following: > > var byte src_ptr[2] AT buffer_addr > FSR1L = src_ptr[0] > FSR1H = src_ptr[1] > > then each call of POSTINC1 reads one byte from the buffer > > > I would like to change this usage to the following: > > 1. Put this in the USB lib, before calling usb_ep_data_out_callback() > var byte src_ptr[2] AT buffer_addr > FSR1L = src_ptr[0] > FSR1H = src_ptr[1] > > 2. Create a inline usb_out_buffer'get function for POSTINC1 > > There is no need to change API. I will keep "word in buffer_addr" in > usb_ep_data_out_callback parameters, although it would no longer be > needed. These suggestions would not affect anyone's current code. > > It took me longer then needed to figure out what these registers do > since they are not named well, and there are no comments. > > Matt. > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
