Comment #7 on issue 158 by [email protected]: Serial hardware
init() should include pin direction settings
http://code.google.com/p/jallib/issues/detail?id=158
"weird" might not be the word :)
What I mean is, as you noticed, serial_hardware doesn't need pin definition
since TX/RX pins are implicit. The question would be, in this case, does
direction have to be implicit too. It looks ok to me to set direction when
you have dealt with pin definition just before, but it looks "strange"
(well, maybe not user-friendly) to deal with pin direction explicitely
whereas in the code you didn't even mention any pin. JSG could be: "let
user sets pin direction, except for library acessing peripherals where pins
are implicit, in this case library will take of proper settings.".
There's no issue in the end here, we can stay as it is currently. I just
wanted to mention this in case we need to reconsider this rule.
Cheers,
seb
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en.
