Hi Matt, I am not going to debate sample generation tools again.
I am in the process of cleaning up the sample directory and my plan is simple: * categorize each sample by it's generation method. * clean namespaces of samples so only one method is used per namespace. * evaluate 'generated by hand' samples; either convert them to generated, keep them or remove them. My tool is 'the old jallib tool', jallib.py. It's not perfect, but it works for 466 of the samples, which are 60% of the non-blink samples. And for my motivation: IMHO cleanup of the sample directory at this point in time is important for the future of jallib. It would be great if someone provides similar samples created in another, better way. Please do so. Joep 2014-03-05 13:16 GMT+01:00 mattschinkel <[email protected]>: > Joep, > > I looked at your method of sample generation again. > > My issue with it is that you have a lot of duplicate code, which is > generally not good practice. If you look at board_18f4620_js.jal and > board18f2550_js.jal, you can see that both files contain: > > ;@jallib section serial > const serial_hw_baudrate = 115_200 > > So, if that section should change, you would have to replace this in all > your files. If you miss any files, some generated samples will suffer. > > And again, I see serial code in test files test_debig.jal and > test_bit_array.jal. Don't u you use the serial code from the board file? > Why duplicate between the test files and the board files? > > The good news however, is that I may be able to generate these board files > via my generation method. What program do you use to make the board files > into samples? Do they auto generate if I modify a board file or sample? > > I'm not sure about generating the "test_" files, but I'll look into it. > > I also don't see how your generation method knows what samples to > generate, and what board file to use for each test sample. > > Matt. > > > On Wednesday, March 5, 2014 2:11:20 AM UTC-5, Joep wrote: >> >> Hi Matt, >> >> >> > I think we need to communicate on what samples each of us should >> generate. >> > For example, I see that you are generating debug samples now, but >> instead, >> > you could ask me to generate for the devices you need samples for. >> You were not here, so I decided to take convert some of your sample to >> the jallib.py methode, so more chips and more benefit. I choose generic >> samples that should run on many chips. >> >> > We don't both need to generate samples for the same namespace. >> That's my intention. >> >> > I agree that only generated samples should be kept for each name space, >> and all manually created ones should be removed. >> That's not my suggestion. >> My suggestion is: one generation method per namespace. So multiple manual >> generated samples can exist in a namespace. (if this is the best way, is >> another question). >> >> > I see 18f67j50_debug.jal and others I generated were removed. I need to >> regenerate debug samples (I have made minor changes to the sample code). >> Please not. My suggestion is you don't don't generate samples your >> scripts anymore for the ones I have converted to the jallib.py mehod and >> remove the remaining ones. If you have a problem with that, I'll remove >> mine from that namespace. >> >> > but yours required more work for me to generate samples. >> It is not my method. It is the one developed by Seb for jallib and used >> by Seb, Albert and myself. I just took up the maintenance task for these >> samples. And yes, it may take some effort to get familiar with this method, >> but it is quite suitable - at least for the more generic sampels - and it >> pays off in the long term. Imagine all samples of Seb and Albert gone. >> >> Joep >> > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/jallib. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/jallib. For more options, visit https://groups.google.com/groups/opt_out.
