Hi, I installed Ubuntu, Python, run validation script, fixed errors and commited. Next time this will be simple :).
Br, Urmas reede, 31. oktoober 2014 21:39.28 UTC+2 kirjutas Matthew Schinkel: > > What is your suggestion Vasi? How much time should be given? > > My plan is to remove them for now and work with Urmas to have them fixed. > > Matt. > > On Friday, October 31, 2014 12:45:37 PM UTC-4, funlw65(Vasi) wrote: >> >> We understand why this "I will have to remove the files if they are not >> fixed soon.". >> >> But guys, is so "encouraging" and "productive" regarding previous >> discussions about Jallib procedures and future contributions... nothing >> changed for the better. Keep up the trend. >> >> On Fri, Oct 31, 2014 at 1:33 PM, Matthew Schinkel <[email protected] >> <javascript:>> wrote: >> >>> Hi Urmas, >>> >>> Buildbot is still failing to compile your sample, and your lib/sample >>> still don't have a correct header. >>> >>> I can do the python jallib.py validate for you, but you need to fix the >>> rest first. >>> >>> I will have to remove the files if they are not fixed soon. >>> >>> Thanks. >>> Matt. >>> >>> On Monday, October 27, 2014 6:15:11 PM UTC-4, Urmas Joeleht wrote: >>>> >>>> Hi, >>>> >>>> Thank you for your advice. I'll correct those variable names and >>>> revision info. Unfortunately I don't have any computers where I can use >>>> python at the moment, but I will in future. I'm totally agree, that >>>> libraries should meet agreed standards. >>>> >>>> Rob, for this sample I only added couple of lines, the base was made by >>>> you, so taking honour as author seemed too much :). >>>> >>>> I have couple of questions also. So far I am using compiler v. 2.4o. >>>> Some time ago I tried also 2.4.p, but spent lot of time by fixing "correct >>>> code" (that worked fine with 2.4o). If I write library today, with which >>>> compiler version it is best practice to ensure all works fine? >>>> >>>> I have couple of glcd libraries, I will "write clean" and share. I >>>> don't remember where (jallist?) I read, that there is thoughts to make >>>> some >>>> kind of changes with glcd library. Unification or smth. When I start >>>> cleaning, I could already make those to accept future plans. Do you know >>>> about plans with glcd? >>>> >>>> Br, >>>> Urmas >>>> ------- >>>> >>>> >>>> esmaspäev, 27. oktoober 2014 20:45.21 UTC+2 kirjutas Sebastien Lelong: >>>> >>>> Hi Rob, >>>> >>>> >>>> On 27 October 2014 16:21, Rob Hamerling <[email protected]> wrote: >>>> >>>> >>>> What type of check is done by bee robot on the samples? >>>> >>>> In the output of buildbot (package.stio) I don't see any compiler >>>> activity, so I think I may assume that the samples aren't compiled by the >>>> bee robot. >>>> >>>> >>>> Buildbot creates an archive according to what's declated in TORELEASE. >>>> Then, once created, it tests it: compilation using embedded compiler. See >>>> Makefile, "bee-check" target: >>>> >>>> bee-check: >>>> >>>> sh check_package.sh distrib/jallib-pack-${VERSION}/lib >>>> distrib/jallib-pack-${VERSION}/sample distrib/jallib-pack-${VERSION} >>>> /compiler/jalv2 >>>> >>>> check_package.sh compiles all samples in archive. >>>> >>>> >>>> Anyway, after I sent my message I realised that compilation is not >>>> relevant in this case, because the bmp085 sample compiles without errors. >>>> It is Jallib validation which complains about the bmp085 library and >>>> sample. So it looks like the bee build doesn't contain a validation either. >>>> >>>> >>>> Indeed, no validation, also because bmp085 isn't in TORELEASE as you >>>> noticed before, it's not part of bee build. >>>> >>>> Hope this is clearer :) >>>> >>>> Cheers >>>> s. >>>> >>>> >>>> >>>> >>>> On 27.10.14 11:31, Sebastien Lelong wrote: >>>> > >>>> >>>> >> Urmas, It's good to see buildbot worked this time. >>>> > >>>> > >>>> > Well that is not so surprising (to me). The 'bee' robot produces only >>>> a download package, it doesn't compile the samples. And the bmp085 >>>> library and sample are not yet in TORELEASE, so these wi >>>> >>>> ... >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "jallib" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> To post to this group, send email to [email protected] >>> <javascript:>. >>> Visit this group at http://groups.google.com/group/jallib. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Vasi >> > -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/jallib. For more options, visit https://groups.google.com/d/optout.
