Hi Rob,
for reference, what kind of errors there were?
I add text file with validation "screenshot".
I made validation, fixed errors, controlled, got 0 errors, 0 warnings.
Should I use some kind of keys with validation script?
Regards,
Urmas
On Tue, Nov 4, 2014 at 10:07 AM, Rob Hamerling <[email protected]>
wrote:
>
> Hi Urmas,
>
> On 03.11.14 09:52, Urmas Joeleht wrote:
>
> I installed Ubuntu, Python, run validation script, fixed errors and
>> commited. Next time this will be simple :).
>>
>
> Don't know why your validation process didn't catch the remaining
> validation issues with your bmp085 library, but I've repaired them for you.
>
> Regards, Rob.
>
> --
> R. Hamerling, Netherlands --- http://www.robh.nl
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "jallib" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jallib/Kf7ak7cMZjk/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/jallib.
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/jallib.
For more options, visit https://groups.google.com/d/optout.
...
A jallib/jat/targets/arduino/cbuild
A jallib/jat/targets/arduino/include
A jallib/jat/targets/arduino/jaltarget.h
Checked out revision 3602.
urmas@Labor:~$ python jallib/tools/jallib.py validate
jallib/include/external/pressure/bmp085.jal
File: jallib/include/external/pressure/bmp085.jal
7 errors found
ERROR: bmp085.jal:88: found a space before parenthesis: 'function
get_uncompensated_temp (bit out ack) return word is\r\n'
ERROR: bmp085.jal:117: found a space before parenthesis: 'function
get_uncompensated_pressure (byte in mode, bit out ack) return byte*3 is\r\n'
ERROR: bmp085.jal:158: found a space before parenthesis: 'procedure
bmp085_init (bit out ack) is\r\n'
ERROR: bmp085.jal:174: found a space before parenthesis: 'function
calculate_true_temperature (word in uncomp_t) return sword is\r\n'
ERROR: bmp085.jal:186: found a space before parenthesis: 'function
calculate_true_pressure (byte*3 in uncomp_p, byte in mode) return dword is\r\n'
ERROR: bmp085.jal:213: found a space before parenthesis: 'procedure
bmp085_return_temperature_and_pressure (byte in mode, sword out temperature,
dword out pressure, bit out success) is\r\n'
ERROR: bmp085.jal:229: found a space before parenthesis: 'procedure
bmp085_return_temperature_and_pressure_fast (byte in mode, sword out
temperature, dword out pressure, bit out success) is\r\n'
0 warnings found
urmas@Labor:~$ python jallib/tools/jallib.py validate
jallib/include/external/pressure/bmp085.jal
File: jallib/include/external/pressure/bmp085.jal
0 errors found
0 warnings found
urmas@Labor:~$ python jallib/tools/jallib.py validate
jallib/sample/16f1519_bmp085.jal
File: jallib/sample/16f1519_bmp085.jal
6 errors found
ERROR: 16f1519_bmp085.jal:Cannot find references to jallib (should
have: '^-- This file is part of
(jallib|jaluino)\\s+\\(http://(jallib|jaluino).googlecode.com\\)')
ERROR: 16f1519_bmp085.jal:Cannot find references to license
ERROR: 16f1519_bmp085.jal:Cannot find field Title (searched for '^--
Title:\s*(.*)')
ERROR: 16f1519_bmp085.jal:Cannot find field Author (searched for '^--
Author:\s*(.*)')
ERROR: 16f1519_bmp085.jal:Cannot find field Compiler (searched for '^--
Compiler:\s*(.*)')
ERROR: 16f1519_bmp085.jal:Cannot find field Description (searched for
'^-- Description:\s*(.*)')
0 warnings found
urmas@Labor:~$ python jallib/tools/jallib.py validate
jallib/sample/16f1519_bmp085.jal
File: jallib/sample/16f1519_bmp085.jal
0 errors found
0 warnings found
urmas@Labor:~$