Danny,
OK, helloName it is, then. Are you being specific that you want it as a
separate element (as opposed to an attribute), or were you just indicating
the name? In other words:
<james>
<postmaster/>
<helloName> OPTION 1 </helloName>
<servernames helloName="OPTION 2" />
<usernames/>
<inboxRepository/>
</james>
Next up ... the interface. getAttribute("helloName") or getHelloName()? If
the latter, let me point out that MailServer does not have attributes
(MailContext does, though).
--- Noel
-----Original Message-----
From: Danny Angus [mailto:[EMAIL PROTECTED]]
Sent: Monday, August 19, 2002 10:21
To: James Developers List
Subject: RE: [PATCH] james-config.xml/james.java
I believe that we should use <helloName> as for the connection handlers, for
consistent naming, I know the use will be slightly different, in that its
not used for hello, but I don't think its so far out to as be wrong as its
still the name we identify ourselves by.
d.
> -----Original Message-----
> From: Noel J. Bergman [mailto:[EMAIL PROTECTED]]
> Sent: 19 August 2002 00:22
> To: James Developers List
> Subject: RE: [PATCH] james-config.xml/james.java
>
>
> Danny,
>
> I'll be happy to make that change. What attribute name for
> MailetContext.getAttribute() would you like for me to use?
> Constants.HELLO_NAME? By "root of the config", do you mean an
> child element of the <James> section? Do you want this to be
> an element or an attribute, e.g.,
>
> <james>
> <postmaster/>
> <servername> OPTION 1 </servername>
> <servernames helloName="OPTION 2" />
> <usernames/>
> <inboxRepository/>
> </james>
>
> I'd like to use this in BaseConnectionHandler.configure() to
> autodetect the
> helloName:
>
> if (autodetect) {
> helloName = defaultHelloName != null ? defaultHelloName :
> hostName;
> }
> else
> helloName = helloConf.getValue("localhost");
>
> To do this, I propose restoring this line of code in James:
>
> //compMgr.put("org.apache.mailet.MailetContext", this);
>
> so that I can request the attribute from James in
> BaseConnectionHandler.configure().
>
> --- Noel
>
> -----Original Message-----
> From: Danny Angus [mailto:[EMAIL PROTECTED]]
>
> I like the servername attribute for remote delivery, I believe that we
> should actually add it at the root of config, and make it available to all
> mailets as a parameter in the context, to be added to the mailet API in
> time. see my other mail regarding ipaddresses.
>
> d.
>
> > -----Original Message-----
> > From: Noel J. Bergman [mailto:[EMAIL PROTECTED]]
> [clip]
> > As submitted in a separate patch, RemoteDelivery.java has already had a
> > <serverName> attribute added to it. With out, James uses the
> > first name in the server name collection, which would often be either
> > localhost or, if autodetected were turned on, the internal name of the
> > computer. This behavior was undocumented, and with the HashSet change
> > is undefined. I've updated the james-config.xml comments for this new
> > element. The <serverName> element is necessary with the HashSet change,
> > but is otherwise still useful (and optional).
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
