Minor correction. I went back and looked. The ORIGINAL identification of
this problem was made by Steve Short and Shilpa Dalmia of PostX back in
mid-May. They raised this issue on the the Avalon Developers list on May
17, and on the James Developers list three days later.
And I quote Peter Donald:
SS: Here is why we raised this as an issue. The Apache James mail server
SS: project is using this timer mechanism to implement a connection timeout
on
SS: the SMTP port. When it receives data on the the port, it calls
SS: resetTrigger to resets the timer.
PD: ouch it is not really designed for that!
After reading through the related Avalon and James classes, I proposed a
watchdog on May 21. I missed one thing in terms of the magnitude of objects
created, which Serge corrected, but he did note on May 22 that: "Looks
rather serious... like you said, perhaps building our own trigger mechanism
is the way to go."
Andrei Ivanov reported load test problems with James on May 30, and then
submitted the first version of the re-factored classes on June 3, reporting
that he was able to successfully load test with the changes ("from 6req/s
and crash -> 26req/s no crash").
It was Andrei who did the basic re-factoring, including: "I replaced
BaseConnectionHandler with AbstractServer which implements
ConnectionHandlerFactory. Every other server class can now inherit from new
AbstractServer by implementing its 'public abstract
createConnectionHandler()'." He re-submitted in late July when they still
hadn't been committed (both Serge and Danny knew about them, but neither had
time to deal with them, as Danny apologized), and then again in mid-August.
At that point, Peter said that he'd take care of picking up Andrei's code,
re-doing all of the services to use it (Andrei had only done SMTP), and
hoped to have it in the code base about a week later. Unfortunately, Peter
got side tracked on all sorts of other Committer responsibilities (e.g.,
testing and committing other fixes that needed to be done), but this change
is finally ready for the CVS.
That pretty much covers the long history of these two change areas.
--- Noel
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
