----- Original Message -----
From: "Peter M. Goldstein" <[EMAIL PROTECTED]>
> It was run a great deal more than once.  Of course in my config, the var
> is deliberately kept at root.  So I wouldn't see this issue.

The last refactoring had caused a NullPointerException and Sever not
starting.

MODE READER is the first command sent by an NNTP Client.
As you can probabaly see it is broken...

Your intent is good and changes knowledgeable, but neither justifies
removing work done by others(effective veto over other folks work) nor does
it justify breaking things. At least have a test or two. I could have
checked in the auth fix a few hours back but I am holding off till I have a
regression test...


Here is the MODE READER implementation. Argument as sent by outlook express
is null.
yielding
S: 501 Syntax error - unexpected parameter
S: 200 Posting Permitted

    private void doMODEREADER(String argument) {
        // 7.2
        if ( argument != null ) {
            writer.println("501 Syntax error - unexpected parameter");
        }
        writer.println(theConfigData.getNNTPRepository().isReadOnly()
                       ? "201 Posting Not Permitted" : "200 Posting
Permitted");
    }

Harmeet


--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@;jakarta.apache.org>

Reply via email to