noel 2003/02/04 11:38:30
Modified: src/java/org/apache/james/nntpserver/repository Tag:
branch_2_1_fcs NNTPSpooler.java
src/java/org/apache/james/transport Tag: branch_2_1_fcs
JamesSpoolManager.java
src/java/org/apache/james/transport/mailets Tag:
branch_2_1_fcs RemoteDelivery.java
src/java/org/apache/james/util/connection Tag:
branch_2_1_fcs ServerConnection.java
Log:
Runnables should log all exceptions in run() - Avalon Excalibur WorkerThread doesn't
Revision Changes Path
No revision
No revision
1.11.4.3 +1 -1
jakarta-james/src/java/org/apache/james/nntpserver/repository/NNTPSpooler.java
Index: NNTPSpooler.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/nntpserver/repository/NNTPSpooler.java,v
retrieving revision 1.11.4.2
retrieving revision 1.11.4.3
diff -u -r1.11.4.2 -r1.11.4.3
--- NNTPSpooler.java 1 Feb 2003 21:00:29 -0000 1.11.4.2
+++ NNTPSpooler.java 4 Feb 2003 19:38:28 -0000 1.11.4.3
@@ -214,7 +214,7 @@
getLogger().debug("Processing file:
"+f.getAbsolutePath());
try {
process(f);
- } catch(Exception ex) {
+ } catch(Throwable ex) {
getLogger().debug("Exception occured while
processing file: "+
f.getAbsolutePath(),ex);
} finally {
No revision
No revision
1.20.4.2 +3 -3
jakarta-james/src/java/org/apache/james/transport/JamesSpoolManager.java
Index: JamesSpoolManager.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/transport/JamesSpoolManager.java,v
retrieving revision 1.20.4.1
retrieving revision 1.20.4.2
diff -u -r1.20.4.1 -r1.20.4.2
--- JamesSpoolManager.java 1 Feb 2003 20:12:54 -0000 1.20.4.1
+++ JamesSpoolManager.java 4 Feb 2003 19:38:29 -0000 1.20.4.2
@@ -335,11 +335,11 @@
spool.unlock(key);
}
mail = null;
- } catch (Exception e) {
+ } catch (Throwable e) {
e.printStackTrace();
if (getLogger().isErrorEnabled()) {
getLogger().error("Exception in JamesSpoolManager.run "
- + e.getMessage());
+ + e.getMessage(), e);
}
}
}
No revision
No revision
1.33.4.1 +2 -2
jakarta-james/src/java/org/apache/james/transport/mailets/RemoteDelivery.java
Index: RemoteDelivery.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/transport/mailets/RemoteDelivery.java,v
retrieving revision 1.33
retrieving revision 1.33.4.1
diff -u -r1.33 -r1.33.4.1
--- RemoteDelivery.java 14 Dec 2002 03:30:11 -0000 1.33
+++ RemoteDelivery.java 4 Feb 2003 19:38:29 -0000 1.33.4.1
@@ -605,7 +605,7 @@
outgoing.remove(key);
throw e;
}
- } catch (Exception e) {
+ } catch (Throwable e) {
log("Exception caught in RemoteDelivery.run(): " + e);
}
}
No revision
No revision
1.3.4.1 +2 -2
jakarta-james/src/java/org/apache/james/util/connection/ServerConnection.java
Index: ServerConnection.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/util/connection/ServerConnection.java,v
retrieving revision 1.3
retrieving revision 1.3.4.1
diff -u -r1.3 -r1.3.4.1
--- ServerConnection.java 30 Oct 2002 10:34:58 -0000 1.3
+++ ServerConnection.java 4 Feb 2003 19:38:29 -0000 1.3.4.1
@@ -317,7 +317,7 @@
}
} catch( IOException ioe ) {
getLogger().error( "Exception accepting connection", ioe );
- } catch( Exception e ) {
+ } catch( Throwable e ) {
getLogger().error( "Exception executing client connection runner: "
+ e.getMessage(), e );
}
}
@@ -408,7 +408,7 @@
getLogger().debug( message );
}
- } catch( Exception e ) {
+ } catch( Throwable e ) {
getLogger().error( "Error handling connection", e );
} finally {
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
