noel 2003/02/04 13:06:00
Modified: src/java/org/apache/james/nntpserver/repository
NNTPSpooler.java
src/java/org/apache/james/transport JamesSpoolManager.java
src/java/org/apache/james/transport/mailets
RemoteDelivery.java
src/java/org/apache/james/util/connection
ServerConnection.java
Log:
Runnables should log all exceptions in run() - Avalon Excalibur WorkerThread doesn't
Revision Changes Path
1.17 +1 -1
jakarta-james/src/java/org/apache/james/nntpserver/repository/NNTPSpooler.java
Index: NNTPSpooler.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/nntpserver/repository/NNTPSpooler.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- NNTPSpooler.java 1 Feb 2003 21:02:16 -0000 1.16
+++ NNTPSpooler.java 4 Feb 2003 21:05:54 -0000 1.17
@@ -214,7 +214,7 @@
getLogger().debug("Processing file:
"+f.getAbsolutePath());
try {
process(f);
- } catch(Exception ex) {
+ } catch(Throwable ex) {
getLogger().debug("Exception occured while
processing file: "+
f.getAbsolutePath(),ex);
} finally {
1.27 +3 -3
jakarta-james/src/java/org/apache/james/transport/JamesSpoolManager.java
Index: JamesSpoolManager.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/transport/JamesSpoolManager.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- JamesSpoolManager.java 1 Feb 2003 20:13:33 -0000 1.26
+++ JamesSpoolManager.java 4 Feb 2003 21:05:55 -0000 1.27
@@ -290,10 +290,10 @@
spool.unlock(key);
}
mail = null;
- } catch (Exception e) {
+ } catch (Throwable e) {
e.printStackTrace();
if (getLogger().isErrorEnabled()) {
- getLogger().error("Exception in JamesSpoolManager.run " +
e.getMessage());
+ getLogger().error("Exception in JamesSpoolManager.run " +
e.getMessage(), e);
}
}
}
1.41 +3 -3
jakarta-james/src/java/org/apache/james/transport/mailets/RemoteDelivery.java
Index: RemoteDelivery.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/transport/mailets/RemoteDelivery.java,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- RemoteDelivery.java 14 Jan 2003 13:41:56 -0000 1.40
+++ RemoteDelivery.java 4 Feb 2003 21:05:56 -0000 1.41
@@ -602,8 +602,8 @@
outgoing.remove(key);
throw e;
}
- } catch (Exception e) {
- log("Exception caught in RemoteDelivery.run(): " + e);
+ } catch (Throwable e) {
+ if (!destroyed) log("Exception caught in RemoteDelivery.run():
" + e);
}
}
} finally {
1.6 +2 -2
jakarta-james/src/java/org/apache/james/util/connection/ServerConnection.java
Index: ServerConnection.java
===================================================================
RCS file:
/home/cvs/jakarta-james/src/java/org/apache/james/util/connection/ServerConnection.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ServerConnection.java 14 Jan 2003 13:42:07 -0000 1.5
+++ ServerConnection.java 4 Feb 2003 21:05:59 -0000 1.6
@@ -315,7 +315,7 @@
}
} catch( IOException ioe ) {
getLogger().error( "Exception accepting connection", ioe );
- } catch( Exception e ) {
+ } catch( Throwable e ) {
getLogger().error( "Exception executing client connection runner: "
+ e.getMessage(), e );
}
}
@@ -404,7 +404,7 @@
getLogger().debug( message );
}
- } catch( Exception e ) {
+ } catch( Throwable e ) {
getLogger().error( "Error handling connection", e );
} finally {
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
