Hi,
Just started working on the changes for the JdbcMailRepository (I hope late is
better than never), and I came accross the following in SqlResources.java
public String getSqlString(String name, boolean required)
{
String sql = getSqlString(name);
if ( sql == null ) {
StringBuffer exceptionBuffer =
new StringBuffer(64)
.append("Required SQL resource: '")
.append(name)
.append("' was not found.");
throw new RuntimeException(exceptionBuffer.toString());
}
return sql;
}
Note, that the required parameter is never checked.
Now as I would like to call this with required=false, I will change it to the
obvious correct code.
The question is now, does this qualify as a separate patch, or can it be
bundled with the patch for JdbcMailRepository?
Also in the same line, I have proposed a set of matchers/mailets which
operates on mail attributes. I guess they would be preferred in a separate
patch, but is a patch preferred for each mailet/matcher or will it be
preferred to submit them in one patch.
Regards
S�ren
--
S�ren Hilmer, M.Sc.
R&D manager Phone: +45 70 27 64 00
TietoEnator IT+ A/S Fax: +45 70 27 64 40
Ved Lunden 12 Direct: +45 87 46 64 57
DK-8230 �byh�j Email: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
