> Note, that the required parameter is never checked. > Now as I would like to call this with required=false, I will > change it to the > obvious correct code. > The question is now, does this qualify as a separate patch, or can it be > bundled with the patch for JdbcMailRepository?
I'd submit it seperately, so it gets a distinct mention in the cvs log > Also in the same line, I have proposed a set of matchers/mailets which > operates on mail attributes. I guess they would be preferred in a > separate > patch, but is a patch preferred for each mailet/matcher or will it be > preferred to submit them in one patch. All in one patch would be fine I guess, if you also submit documentation patches to cover them... :-) d.
