Noel, > I'll get it committed. In the meantime, would you please look at: > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18028 > > I believe that the new code still has that problem. I've a tentative > solution in mind that I'll post after committing your submission.
I see that you already fixed it in the new code, right? > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18309 > > > NotifyPostmaster had a slightly richer [notification message, which] > > has become the common one for all three. > > The request in 18309 might apply to AbstractNotify. I'll have a look at it. > > > I'm wondering if the fake sender domain check done in Forward > > should be shared by all the mailets. > > Possibly, but it should only be done if we are going to USE the Sender > domain. If we are just forwarding the message from Postmaster, > for example, > we don't USE the original Sender, and can preserve it. This is useful if > you have a mailet like: > > <mailet match="All" class="Redirect"> > <recipients>[EMAIL PROTECTED]</recipients> > <sender>postmaster</sender> > <returnpath>null</returnpath> > <inline>unaltered</inline> > <passThrough>true</passThrough> > <static>true</static> > </mailet> > I'll have a look at it. > All in all, Vincenzo, I think you've done a great job! :-) Thank you, specially coming from you! :-) I downloaded from CVS (tag MAIN) the sources with your committed changes and had a look at it. 1) You changed import org.apache.james.util.RFC2822Headers; to import org.apache.mailet.RFC2822Headers; But such file is not in org.apache.mailet. I downloaded also james-with-phoenix-2.2.0a3-src.zip and all your fixes seem to be there, excluding this one. I'm a little bit confused, could you readdress me? In the meantime I will continue with james-with-phoenix-2.2.0a3-src.zip 2) I had forgotten to clean the imports; many of them should not be necessary: shall I do that? By the way, all around in the code the imports are done class by class, instead of package.*; is it a practice to be always enforced? 3) In my message sending the code I forgot to say that I had done some minor cleanup of redundant code (getSpecialAddress), and you probably saw that. Some more cleanup can be done all around, but for the moment I think that is better to wait for feedback from tests: do you agree? Vincenzo --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
