Vincenzo, Yes, I fixed the code to use getAtachmentType(originalMail). I also attempted a fix for 18028, which hopefully does the trick.
The http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18309 change would be a nice thing to do, but not something to hold up a release. The sender in fake domain check could be done for the originator fields. > I downloaded from CVS (tag MAIN) the sources with your committed > changes and had a look at it. > You changed > import org.apache.james.util.RFC2822Headers; > to > import org.apache.mailet.RFC2822Headers; That is only in HEAD, which is for James v3. Danny reorganized the code, and moved additional classes into the org.apache.mailet package. In James v2, those are in org.apache.james.util, so I had to modify the code that is in HEAD (v3) compared to what is in branch_2_1_fcs (v2). I did remove a number of unused imports, specifically the ones above. It makes it easier to keep the two branches in synch. Yes, please do clean the imports if you've time. I think that Danny had decided a while back to import specific classes rather than entire packages when possible, but it hasn't raised as a big issue. Personally, I tend to just use the fully qualified class name if I'm just using it once or twice. > Some more cleanup can be done all around, but for the moment > I think that is better to wait for feedback from tests: do > you agree? Hopefully we'll get some feedback. Danny is using James HEAD, as I understand it, and is the original author of Redirect, so I am particularly keen to see if he has his own Redirect-based extensions, and whether or not they are continuing to work properly with the new code in HEAD. --- Noel --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
