[ 
http://issues.apache.org/jira/browse/LUCENE-627?page=comments#action_12421347 ] 
            
Yonik Seeley commented on LUCENE-627:
-------------------------------------

> 1) TokenGroup.getTotalScore should just return your new "tot" variable

OK, I had considered that change before, but because all the vars were package 
protected rather than private, I wasn't sure if it was safe.

> 2) TokenGroup.clear() needs to reinitialize "tot" to zero.

Oops... that one I missed.

> Other than that all looks good to me. Let me know if you're happy and I'll 
> commit it.

Looks fine to me... please do!


> highlighter problems with overlapping tokens
> --------------------------------------------
>
>                 Key: LUCENE-627
>                 URL: http://issues.apache.org/jira/browse/LUCENE-627
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.0.1
>            Reporter: Yonik Seeley
>         Attachments: highlight_overlap.diff
>
>
> The lucene highlighter has problems when tokens that overlap are generated.
> For example, if analysis of iPod generates the tokens "i", "pod", "ipod" 
> (with pod and ipod in the same position),
> then the highlighter will output this as iipod, regardless of if any of those 
> tokens are highlighted.
> Discovered via http://issues.apache.org/jira/browse/SOLR-24

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to