[ 
http://issues.apache.org/jira/browse/LUCENE-657?page=comments#action_12443946 ] 
            
Yonik Seeley commented on LUCENE-657:
-------------------------------------

Making the class non-final is fine.

As far as changing members to protected, I'm not opposed to opening something 
up a little more so the very expert users don't have to copy the class 
(although that is often an option).  In return, those expert users shouldn't 
complain if the internals change ;-)

> FuzzyQuery should not be final
> ------------------------------
>
>                 Key: LUCENE-657
>                 URL: http://issues.apache.org/jira/browse/LUCENE-657
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>         Environment: all platforms
>            Reporter: Andreas Neumann
>         Assigned To: Steven Parkes
>            Priority: Trivial
>             Fix For: 2.1
>
>         Attachments: fuzzy.patch
>
>
> I am trying to extend the FuzzyQuery to further filter the TermEnum. (I am 
> indexing stem forms and original forms, but I only want to match original 
> forms with a fuzzy term, otherwise I get to much noise). However, FuzzyQuery 
> is a final class and I cannot extend it.  
> As discussed in the mailing list 
> (http://www.gossamer-threads.com/lists/lucene/java-dev/38756), we want to 
> make the private variables and inner classes protected.
> I am attaching a patch for FuzzyQuery.java that implements this. I ran all 
> unit tests and they passed without errors.
> Andreas.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to