[
https://issues.apache.org/jira/browse/LUCENE-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doron Cohen updated LUCENE-837:
-------------------------------
Attachment: benchmark-more-updates.patch
The changes looks good.
I integrated in my changes:
- Modified query-maker generation for read related tasks to make further read
tasks addition simpler and safer.
- Changed Taks' setParams() to throw UnsupportedOperationException if that task
does not suppot command line param.
- Improved javadoc to specify all properties command line params currently
supported.
- Refactored ReportTasks so that it is easy/possible now to create new report
tasks.
If you feel comfortable with committng them together, that would be great. Or,
if you prefer to commit yours first, I'll reintegrate mine later. The changes
are supposed to allow you now to easily add new report tasks.
I also modified the micro-standard.alg to use the new traverse params.
(I didn't try the new file based query makers.)
Attached file (benchmark-more-updates.patch) contains the changes from
benchmark-updates.patch.
> contrib/benchmark QueryMaker and Task Refactorings
> --------------------------------------------------
>
> Key: LUCENE-837
> URL: https://issues.apache.org/jira/browse/LUCENE-837
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/benchmark
> Reporter: Grant Ingersoll
> Assigned To: Grant Ingersoll
> Priority: Minor
> Attachments: benchmark-more-updates.patch, benchmark-updates.patch
>
>
> Introduce an abstract QueryMaker implementation that shares much of the
> common code between the various QueryMaker implementations.
> Add in a new QueryMaker for reading queries from a file that is specified in
> the properties.
> Patch shortly, and if no concerns, will commit tomorrow or Wed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
