[
https://issues.apache.org/jira/browse/LUCENE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484383
]
Michael McCandless commented on LUCENE-431:
-------------------------------------------
Michael, I wasn't able to cleanly apply this patch on the current trunk. I get
this:
patch -p0 < lucene-431.patch
patching file src/java/org/apache/lucene/store/RAMInputStream.java
Hunk #2 FAILED at 21.
1 out of 2 hunks FAILED -- saving rejects to file
src/java/org/apache/lucene/store/RAMInputStream.java.rej
patching file src/java/org/apache/lucene/store/RAMOutputStream.java
Hunk #1 FAILED at 21.
1 out of 3 hunks FAILED -- saving rejects to file
src/java/org/apache/lucene/store/RAMOutputStream.java.rej
patching file src/test/org/apache/lucene/store/MockRAMOutputStream.java
I'd like to test this net performance gain with LUCENE-843. I think fixing
this plus doing LUCENE-843 should make indexing into a RAMDirectory quite a bit
faster.
> RAMInputStream and RAMOutputStream without further buffering
> ------------------------------------------------------------
>
> Key: LUCENE-431
> URL: https://issues.apache.org/jira/browse/LUCENE-431
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Affects Versions: CVS Nightly - Specify date in submission
> Environment: Operating System: other
> Platform: Other
> Reporter: Paul Elschot
> Assigned To: Michael Busch
> Priority: Minor
> Attachments: lucene-431.patch, RAMInputStream.java
>
>
> From java-dev, Doug's reply of 12 Sep 2005
> on Delaying buffer allocation in BufferedIndexInput:
>
> Paul Elschot wrote:
> ...
> > I noticed that RAMIndexInput extends BufferedIndexInput.
> > It has all data in buffers already, so why is there another
> > layer of buffering?
>
> No good reason: it's historical.
>
> To avoid this either: (a) the BufferedIndexInput API would need to be
> modified to permit subclasses to supply the buffer; or (b)
> RAMInputStream could subclass IndexInput directly, using its own
> buffers. The latter would probably be simpler.
>
> End of quote.
>
> I made version (b) of RAMInputStream.
> Using this RAMInputStream, TestTermVectorsReader failed as the only
> failing test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
