[
https://issues.apache.org/jira/browse/LUCENE-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546719
]
Mark Miller commented on LUCENE-1026:
-------------------------------------
Quick comment:
You have the MultiSearcher closing its own IndexAccessor's now. Maybe I messed
up copying in your changes, but this causes an Exception in the tests as the
IndexFactory also closes all of the IndexAccessor's. (Really, it owns them)
It's probably a good idea for the MultiSearcher to have a close (clearing the
two caches is not a bad idea), but I don't think the MultiSearcher should close
IndexAccessors. It does not own those Accessors and other threads may be using
them from the Factory. They are only kept around in the MultiSearcher so that
it can release them later, back to the Factory.
Also, probably the Factory.close method should call the MultiSearcher close
rather than having to get the MuliSearcher and call close separately?
Thoughts?
- Mark
> Provide a simple way to concurrently access a Lucene index from multiple
> threads
> --------------------------------------------------------------------------------
>
> Key: LUCENE-1026
> URL: https://issues.apache.org/jira/browse/LUCENE-1026
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Index, Search
> Reporter: Mark Miller
> Priority: Minor
> Attachments: DefaultIndexAccessor.java,
> DefaultMultiIndexAccessor.java, IndexAccessor.java,
> IndexAccessorFactory.java, MultiIndexAccessor.java, shai-IndexAccessor-2.zip,
> shai-IndexAccessor.zip, shai-IndexAccessor3.zip, SimpleSearchServer.java,
> StopWatch.java, TestIndexAccessor.java
>
>
> For building interactive indexes accessed through a network/internet
> (multiple threads).
> This builds upon the LuceneIndexAccessor patch. That patch was not very
> newbie friendly and did not properly handle MultiSearchers (or at the least
> made it easy to get into trouble).
> This patch simplifies things and provides out of the box support for sharing
> the IndexAccessors across threads. There is also a simple test class and
> example SearchServer to get you started.
> Future revisions will be zipped.
> Works pretty solid as is, but could use the ability to warm new Searchers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
