[ 
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655821#action_12655821
 ] 

markrmil...@gmail.com edited comment on LUCENE-1483 at 12/11/08 4:32 PM:
---------------------------------------------------------------

Okay, so subclasses of HitCollector stay subclasses until 3, and then they 
extend Hitable? Sounds good.
*EDIT*
No that wont work and I read your comment wrong - we have to provide new impls, 
and old impls will be wrapped. Got it. Patch coming.

I kind of like Hitable myself. You are collecting a 'hit' with a Hittable 
object. A hit is a doc and score. Any other opinions? I'm less fond of other 
Collector variations. hit() could be better than collect(), but collect() is 
not such a stretch in my mind.

*EDIT*

One further thought, if we are replacing TopDocCollector, what would it become? 
TopDocDocCollector, TopDocHitable? I'm liking these names less...

      was (Author: markrmil...@gmail.com):
    Okay, so subclasses of HitCollector stay subclasses until 3, and then they 
extend Hitable? Sounds good.
*EDIT*
No that wont work and I read your comment wrong - we have to provide new impls, 
and old impls will be wrapped. Got it. Patch coming.

I kind of like Hitable myself. You are collecting a 'hit' with a Hittable 
object. A hit is a doc and score. Any other opinions? I'm less fond of other 
Collector variations. hit() could be better than collect(), but collect() is 
not such a stretch in my mind.
  
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1483
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, 
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, 
> LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing 
> for individual segment reloading on reopen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to