[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655892#action_12655892 ]
Hoss Man commented on LUCENE-1483: ---------------------------------- I haven't been following this issue too closely (or truthfully: at all) but if there's talk of deprecating HItCollector and introducing a new superclass to replace it, would it also make sense to revist the idea of adding a return type to the collect/hit method? ... ie: an enum style result indicating "OK" or "ABORT" (with the potential of adding additional constants later ala FieldSelectorResult) I remember this coming up as a "wish list" back when TimeLimitedCollector was added (but i don't really remember if it was decided that the current implementation was actually better then if collect() did have a return value) Anyway, just something to ponder... {code} public abstract class Hitable { public abstract void setBase(int base); public abstract HitStatus hit(int doc, float score); } /** @deprecated */ public abstract class HitCollector extends Hitable { public abstract void collect(int doc, float score); public void setBase(int base) { throw new UOE(); } public HitStatus hit(int doc, float score) { collect(doc, score); return HitStatus.OK; } } {code} > Change IndexSearcher to use MultiSearcher semantics for multiple subreaders > --------------------------------------------------------------------------- > > Key: LUCENE-1483 > URL: https://issues.apache.org/jira/browse/LUCENE-1483 > Project: Lucene - Java > Issue Type: Improvement > Affects Versions: 2.9 > Reporter: Mark Miller > Priority: Minor > Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch > > > FieldCache and Filters are forced down to a single segment reader, allowing > for individual segment reloading on reopen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org