[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657745#action_12657745
]
Michael McCandless commented on LUCENE-1483:
--------------------------------------------
Patch is looking good! All tests, and back-compat tests, pass. I'm
going to run a round of perf tests...
Some minor things I noticed:
* Fix indent on FieldComparatorSource.java to 2 spaces
* Leftover "check val" print in FieldComparator.java
* Do we need to track maxScore in TopFieldValueDocCollector (but
mark as deprecated)? (Because Hits isn't removed yet).
* Got some "nocommit" comments to resolve still
* I think StringComparatorLocale should call FieldCache.getStrings
(as it does on trunk now when you do String sort w/ Locale), not
getStringIndex. Then the queue should just hold the String[]
values, not StringIndex[]?
.
(Aside: we could fix StringIndex computation to take a Locale,
which'd give better performance, but that's a separate issue).
* I think you can improve the ord fallback comparator a bit, by
keeping separate "equals" array that's just like subord but is
instead a boolean. Equals is true when the ord is present in the
new segment and false if the string could not be found in the new
segment. Then only fallback to String.compareTo when equals is
false. I think this is important for enum fields because the two
segments will not have the same String object when they are equal.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
