[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657760#action_12657760
]
Mark Miller commented on LUCENE-1483:
-------------------------------------
bq. Fix indent on FieldComparatorSource.java to 2 spaces
Roger.
bq. Leftover "check val" print in FieldComparator.java
I'll be sure to get all of this...i also have a ton of System.outs commented
out that I'll remove.
bq. Do we need to track maxScore in TopFieldValueDocCollector (but mark as
deprecated)? (Because Hits isn't removed yet).
You know it.
bq. Got some "nocommit" comments to resolve still
Right - time to start looking at these, names, and design changes that might
make sense I think.
bq. I think StringComparatorLocale should call FieldCache.getStrings (as it
does on trunk now when you do String sort w/ Locale), not getStringIndex. Then
the queue should just hold the String[] values, not StringIndex[]?
I swear I looked at trunk twice and saw it was using a StringIndex - just
looked again ands its not. I love that.
bq. I think you can improve the ord fallback comparator a bit...
Lets see if its in even in the ballpark yet...if it is, ill tweak it all we can.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
