[ 
https://issues.apache.org/jira/browse/LUCENE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662485#action_12662485
 ] 

Jason Rutherglen commented on LUCENE-1314:
------------------------------------------

That worked Erik.

I executed TestIndexReaderReopen using the LUCENE-1314 patch 8 times via 
command line and did not see the error.  

Then tried TestIndexReaderReopen in trunk and saw this the first time:

{code}
common.test:
    [mkdir] Created dir: /Users/jrutherg/dev/lucenetrunk/trunk/build/test
    [junit] Testsuite: org.apache.lucene.index.TestIndexReaderReopen
    [junit] this IndexReader is closed)
    [junit] Tests run: 15, Failures: 1, Errors: 0, Time elapsed: 19.125 sec
    [junit] 
    [junit] ------------- Standard Output ---------------
    [junit] java.io.FileNotFoundException: _0_6.del
    [junit]     at 
org.apache.lucene.store.RAMDirectory.openInput(RAMDirectory.java:237)
    [junit]     at org.apache.lucene.util.BitVector.<init>(BitVector.java:235)
    [junit]     at 
org.apache.lucene.index.SegmentReader.loadDeletedDocs(SegmentReader.java:412)
    [junit]     at 
org.apache.lucene.index.SegmentReader.reopenSegment(SegmentReader.java:499)
    [junit]     at 
org.apache.lucene.index.MultiSegmentReader.<init>(MultiSegmentReader.java:112)
    [junit]     at 
org.apache.lucene.index.SegmentReader.doReopen(SegmentReader.java:442)
    [junit]     at 
org.apache.lucene.index.DirectoryIndexReader$2.doBody(DirectoryIndexReader.java:153)
    [junit]     at 
org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:688)
    [junit]     at 
org.apache.lucene.index.DirectoryIndexReader.reopen(DirectoryIndexReader.java:175)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$9.run(TestIndexReaderReopen.java:685)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$ReaderThread.run(TestIndexReaderReopen.java:818)
    [junit] org.apache.lucene.store.AlreadyClosedException: this IndexReader is 
closed
    [junit]     at 
org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:196)
    [junit]     at 
org.apache.lucene.index.SegmentReader.docFreq(SegmentReader.java:741)
    [junit]     at 
org.apache.lucene.index.MultiSegmentReader.docFreq(MultiSegmentReader.java:378)
    [junit]     at 
org.apache.lucene.search.IndexSearcher.docFreq(IndexSearcher.java:86)
    [junit]     at org.apache.lucene.search.Similarity.idf(Similarity.java:481)
    [junit]     at 
org.apache.lucene.search.TermQuery$TermWeight.<init>(TermQuery.java:44)
    [junit]     at 
org.apache.lucene.search.TermQuery.createWeight(TermQuery.java:146)
    [junit]     at org.apache.lucene.search.Query.weight(Query.java:95)
    [junit]     at 
org.apache.lucene.search.Searcher.createWeight(Searcher.java:185)
    [junit]     at org.apache.lucene.search.Searcher.search(Searcher.java:136)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$9.run(TestIndexReaderReopen.java:689)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$ReaderThread.run(TestIndexReaderReopen.java:818)
    [junit] ------------- ---------------- ---------------
    [junit] ------------- Standard Error -----------------
    [junit] java.io.FileNotFoundException: _0_6.del
    [junit]     at 
org.apache.lucene.store.RAMDirectory.openInput(RAMDirectory.java:237)
    [junit]     at org.apache.lucene.util.BitVector.<init>(BitVector.java:235)
    [junit]     at 
org.apache.lucene.index.SegmentReader.loadDeletedDocs(SegmentReader.java:412)
    [junit]     at 
org.apache.lucene.index.SegmentReader.reopenSegment(SegmentReader.java:499)
    [junit]     at 
org.apache.lucene.index.MultiSegmentReader.<init>(MultiSegmentReader.java:112)
    [junit]     at 
org.apache.lucene.index.SegmentReader.doReopen(SegmentReader.java:442)
    [junit]     at 
org.apache.lucene.index.DirectoryIndexReader$2.doBody(DirectoryIndexReader.java:153)
    [junit]     at 
org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:688)
    [junit]     at 
org.apache.lucene.index.DirectoryIndexReader.reopen(DirectoryIndexReader.java:175)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$9.run(TestIndexReaderReopen.java:685)
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen$ReaderThread.run(TestIndexReaderReopen.java:818)
    [junit] ------------- ---------------- ---------------
    [junit] Testcase: 
testThreadSafety(org.apache.lucene.index.TestIndexReaderReopen):  FAILED
    [junit] Error occurred in thread Thread-51:
    [junit] this IndexReader is closed
    [junit] junit.framework.AssertionFailedError: Error occurred in thread 
Thread-51:
    [junit] this IndexReader is closed
    [junit]     at 
org.apache.lucene.index.TestIndexReaderReopen.testThreadSafety(TestIndexReaderReopen.java:760)
    [junit] 
    [junit] 
    [junit] Test org.apache.lucene.index.TestIndexReaderReopen FAILED

{code}

> IndexReader.clone
> -----------------
>
>                 Key: LUCENE-1314
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1314
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index
>    Affects Versions: 2.3.1
>            Reporter: Jason Rutherglen
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1314.patch, LUCENE-1314.patch, LUCENE-1314.patch, 
> LUCENE-1314.patch, LUCENE-1314.patch, LUCENE-1314.patch, LUCENE-1314.patch, 
> LUCENE-1314.patch, LUCENE-1314.patch, LUCENE-1314.patch, lucene-1314.patch, 
> lucene-1314.patch, lucene-1314.patch, lucene-1314.patch, lucene-1314.patch, 
> lucene-1314.patch, lucene-1314.patch, lucene-1314.patch, lucene-1314.patch, 
> lucene-1314.patch, lucene-1314.patch, lucene-1314.patch
>
>
> Based on discussion 
> http://www.nabble.com/IndexReader.reopen-issue-td18070256.html.  The problem 
> is reopen returns the same reader if there are no changes, so if docs are 
> deleted from the new reader, they are also reflected in the previous reader 
> which is not always desired behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to