[
https://issues.apache.org/jira/browse/LUCENE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698740#action_12698740
]
Shai Erera commented on LUCENE-1591:
------------------------------------
Not sure what you mean. The test does use any Task, just attempts to parse
algorithm texts with those tasks defined. Do you suggest we exclude
WriteLineDocTask from the test?
Perhaps we can wrap the new Benchmark() call with a try-catch on IAE and log
such tests but don't fail? That way, if a certain task has mandatory
properties, it shouldn't fail the test ...
Another option is to define for each tested task mandatory properties, in
addition to the common ones used for all tasks ...
Unless I misunderstand you, I don't see why this test is wrong.
> Enable bzip compression in benchmark
> ------------------------------------
>
> Key: LUCENE-1591
> URL: https://issues.apache.org/jira/browse/LUCENE-1591
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Shai Erera
> Fix For: 2.9
>
> Attachments: commons-compress-dev20090413.jar,
> commons-compress-dev20090413.jar, LUCENE-1591.patch, LUCENE-1591.patch,
> LUCENE-1591.patch, LUCENE-1591.patch
>
>
> bzip compression can aid the benchmark package by not requiring extracting
> bzip files (such as enwiki) in order to index them. The plan is to add a
> config parameter bzip.compression=true/false and in the relevant tasks either
> decompress the input file or compress the output file using the bzip streams.
> It will add a dependency on ant.jar which contains two classes similar to
> GZIPOutputStream and GZIPInputStream which compress/decompress files using
> the bzip algorithm.
> bzip is known to be superior in its compression performance to the gzip
> algorithm (~20% better compression), although it does the
> compression/decompression a bit slower.
> I wil post a patch which adds this parameter and implement it in
> LineDocMaker, EnwikiDocMaker and WriteLineDoc task. Maybe even add the
> capability to DocMaker or some of the super classes, so it can be inherited
> by all sub-classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
