[ 
https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711790#action_12711790
 ] 

Paul Elschot commented on LUCENE-1436:
--------------------------------------

This should only affect external code that uses the ReqExclScorer class.
>From the amount of reactions on that so far I think such code probably does 
>not exist.

The move to DocIdSetIterator (superclass of Scorer) can be done because no 
score values are used on the excluded part. This is only a consequence of the 
extraction of the DocIdSetIterator superclass from Scorer.

So I don't expect LUCENE-1614 or new semantics of DISI to collide with this.
Also, I don't expect LUCENE-1614 to collide with LUCENE-1345 that allows filter 
as clause to boolean query.

Some time ago DisjunctionSumScorer was made private in a similar way.

ReqOptSumScorer could also be made package private, perhaps even at the same 
time as ReqExclScorer.




> Make ReqExclScorer package private, and use DocIdSetIterator for excluded 
> part.
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-1436
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1436
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Paul Elschot
>            Priority: Trivial
>         Attachments: LUCENE-1436.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to