On Tue, May 26, 2009 at 12:29 PM, Yonik Seeley <yo...@lucidimagination.com> wrote: > On Tue, May 26, 2009 at 12:16 PM, Michael McCandless > <luc...@mikemccandless.com> wrote: >> What other issues are you hitting? > > I hit an NPE when using old-style sort comparators.
Do you have the traceback (or remember the gist)? > The main thing is that I didn't anticipate having to rewrite all the > custom sort comparators Solr has. Because they were loading the FieldCache entry for the entire MultiReader (vs normal field sorting which'd load per segment)? How many custom sort comparators does Solr have? > There are multiple test cases still failing... not sure at this point > if they are all related to custom sort comparators or not. > >> Hmmm... in the past (TopDocCollector in 2.4.x), hits with such scores >> (Nan, -Inf, in fact any non-positive score) were skipped entirely. > > OK... I never actually checked if they were included or not - Solr > used a priority queue directly due to historical Lucene limitations. But are you now migrating away from Solr's private PQ? (Else you wouldn't have hit problems w/ Lucene's new TSDC). Mike --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
