OK I'll commit these changes... Mike
On Tue, May 26, 2009 at 1:34 PM, Shai Erera <ser...@gmail.com> wrote: > I also think we should state that for TSDC, those scores are invalid. > > In fact, we also changed TopDocs to return maxScore=NaN if max-score is not > tracked, so I think in a sense we've already said that NaN is not a valid > value. > > But anyway, given that I don't believe those scores are common, and the > enhancements we could do to TSDC (pre-populating the queue with those > sentinels) I think we should state it for TSDC, and if someone does need to > use those scores, he can write his own version of TSDC, which does not > pre-populate anything, or uses different sentinels. > > I don't think this warrants an issue though. Just a small addition to TSDC's > javadoc and to CHANGES. > > Shai > > On Tue, May 26, 2009 at 7:30 PM, Yonik Seeley <yo...@lucidimagination.com> > wrote: >> >> FYI, the upgrading work is going on in >> https://issues.apache.org/jira/browse/SOLR-1111 >> >> -Yonik >> http://www.lucidimagination.com >> >> >> >> On Tue, May 26, 2009 at 12:29 PM, Yonik Seeley >> <yo...@lucidimagination.com> wrote: >> > On Tue, May 26, 2009 at 12:16 PM, Michael McCandless >> > <luc...@mikemccandless.com> wrote: >> >> What other issues are you hitting? >> > >> > I hit an NPE when using old-style sort comparators. >> > The main thing is that I didn't anticipate having to rewrite all the >> > custom sort comparators Solr has. >> > There are multiple test cases still failing... not sure at this point >> > if they are all related to custom sort comparators or not. >> > >> >> Hmmm... in the past (TopDocCollector in 2.4.x), hits with such scores >> >> (Nan, -Inf, in fact any non-positive score) were skipped entirely. >> > >> > OK... I never actually checked if they were included or not - Solr >> > used a priority queue directly due to historical Lucene limitations. >> > >> > -Yonik >> > http://www.lucidimagination.com >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
