[ 
https://issues.apache.org/jira/browse/LUCENE-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718855#action_12718855
 ] 

Michael McCandless commented on LUCENE-1685:
--------------------------------------------

I consider it a bug that QueryScorer will separately highlight "foo" and "bar" 
when the PhraseQuery "foo bar" was searched on.

Are there actually compelling things that QueryScorer does over SpanScorer?

bq. Actually, perhaps we deprecate SpanScorer and add the functionality to 
QueryScorer with the switch, default to position sensitive.

+1

And that way we keep the more consumable name (QueryScorer).

> Make the Highlighter use SpanScorer by default
> ----------------------------------------------
>
>                 Key: LUCENE-1685
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1685
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.9
>
>
> I've always thought this made sense, but frankly, it took me a year to get 
> the SpanScorer included with Lucene at all, so I was pretty much ready to 
> move on after I it got in, rather than push for it as a default.
> I think it makes sense as the default in Solr as well, and I mentioned that 
> back when it was put in, but alas, its an option there as well.
> The Highlighter package has no back compat req, but custom has been 
> conservative - one reason I havn't pushed for this change before. Might be 
> best to actually make the switch in 3? I could go either way - as is, I know 
> a bunch of people use it, but I'm betting its the large minority. It has 
> never been listed in a changes entry and its not in LIA 1, so you pretty much 
> have to stumble upon it, and figure out what its for.
> I'll point out again that its just as fast as the standard scorer for any 
> clause of a query that is not position sensitive. Position sensitive query 
> clauses will obviously be somewhat slower to highlight, but that is because 
> they will be highlighted correctly rather than ignoring position.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to