On Mon, Jun 15, 2009 at 10:53 PM, Shai Erera<ser...@gmail.com> wrote: > But note that Query has weight() and createWeight(), which I am still > confused about why we have two of them. Maybe I can consolidate them to one?
createWeight() raw weight, and weight() is a top-level normalized weight. I don't think they should be consolidated, but good JavaDoc is needed. But the fact that "weight" is also a non-static public member is further evidence that createWeight() needs to be public (how else would one provide a different implementation?) > Anyway, I think this better be handled as part of LUCENE-1630, since the > Query and Weight classes are touched already in that are exactly. If it's going to make it into 2.9, that's fine. -Yonik http://www.lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
