[ 
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724256#action_12724256
 ] 

Yonik Seeley commented on LUCENE-1707:
--------------------------------------

bq. Do you think that changing ensureOpen() to check "if (refCount == 0)" will 
speed things up a bit? 

Nope - not on any common CPUs.  There is normally a test instruction which sets 
a bunch of status flags - branching on those status flags for less-or-equal is 
the same exact cycle count as equal.

> Don't use ensureOpen() excessively in IndexReader and IndexWriter
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1707
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1707
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>         Attachments: LUCENE-1707.patch, LUCENE-1707.patch
>
>
> A spin off from here: 
> http://www.nabble.com/Excessive-use-of-ensureOpen()-td24127806.html.
> We should stop calling this method when it's not necessary for any internal 
> Lucene code. Currently, this code seems to hurt properly written apps, 
> unnecessarily.
> Will post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to