[
https://issues.apache.org/jira/browse/LUCENE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727612#action_12727612
]
Mark Miller commented on LUCENE-1650:
-------------------------------------
No I'm not :) Yonik, could you take a peak at this?
Why the javadoc change? It used to refer to the method parameter - that makes
sense to me ? Where is valSrcScore bound?
As far as the second change, its a logical change, but it is a back compat
change. I'm thinking it could be considered a bug fix, but the old weirdness
worked if
you followed the javadoc no?
I'm pro the change, and it prob doesnt make sense to add a static or property
to allow the old behaviour, but another opinion...
> Small fix in CustomScoreQuery JavaDoc
> -------------------------------------
>
> Key: LUCENE-1650
> URL: https://issues.apache.org/jira/browse/LUCENE-1650
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Javadocs
> Affects Versions: 2.9, 3.0
> Reporter: Simon Willnauer
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: customScoreQuery_CodeChange+JavaDoc.patch,
> customScoreQuery_JavaDoc.patch, LUCENE-1650.patch
>
>
> I have fixed the javadoc for "Modified Score" formular in CustomScoreQuery.
> - Patch attached: customScoreQuery_JavaDoc.patch
> I'm quite curious why the method:
> public float customScore(int doc, float subQueryScore, float valSrcScores[])
> calls public float customScore(int doc, float subQueryScore, float
> valSrcScore]) only in 2 of the 3 cases which makes the choice to override
> either one of the customScore methods dependent on the number of
> ValueSourceQuery passed to the constructor. I figure it would be more
> consistent if it would call the latter in all 3 cases.
> I also attached a patch which proposes a fix for that issue. The patch does
> also include the JavaDoc issue mentioned above.
> - customScoreQuery_CodeChange+JavaDoc.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
