[
https://issues.apache.org/jira/browse/LUCENE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727688#action_12727688
]
Mark Miller commented on LUCENE-1650:
-------------------------------------
bq. Not sure why you wanted me to take a peek - this isn't part of the original
Solr function query stuff, so I won't know any more than anyone else.
Because you knew that, and I didnt :) And because your pretty smart about these
things. And your usually happy to ignore when you are not interested, so I
figured you always had that out here :) I think there are usually okay odds
that you might know more than someone else.
bq. Anyway the current code looks like it's working as designed? Perhaps it
wasn't the best interface, but not worth breaking compatibility over, and not
necessary to improve for 2.9 IMO.
That's kind of what I started thinking, and I just wanted someone smarter than
me to confirm or deny. It also just seemed like it was *very* unlikely that it
would affect anyone if the change was made, so why not just make it consistent.
I could go either way, but technically it is a backcompat break, and it would
be easier to just leave it.
I'll just push it off 2.9 for now.
I'm just trying to resolve/push 2.9 issues - didnt mean to single you out for
any specific work :)
> Small fix in CustomScoreQuery JavaDoc
> -------------------------------------
>
> Key: LUCENE-1650
> URL: https://issues.apache.org/jira/browse/LUCENE-1650
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Javadocs
> Affects Versions: 2.9, 3.0
> Reporter: Simon Willnauer
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: customScoreQuery_CodeChange+JavaDoc.patch,
> customScoreQuery_JavaDoc.patch, LUCENE-1650.patch, LUCENE-1650.patch
>
>
> I have fixed the javadoc for "Modified Score" formular in CustomScoreQuery.
> - Patch attached: customScoreQuery_JavaDoc.patch
> I'm quite curious why the method:
> public float customScore(int doc, float subQueryScore, float valSrcScores[])
> calls public float customScore(int doc, float subQueryScore, float
> valSrcScore]) only in 2 of the 3 cases which makes the choice to override
> either one of the customScore methods dependent on the number of
> ValueSourceQuery passed to the constructor. I figure it would be more
> consistent if it would call the latter in all 3 cases.
> I also attached a patch which proposes a fix for that issue. The patch does
> also include the JavaDoc issue mentioned above.
> - customScoreQuery_CodeChange+JavaDoc.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
