[
https://issues.apache.org/jira/browse/LUCENE-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732601#action_12732601
]
Mark Miller commented on LUCENE-1748:
-------------------------------------
Something should be done here. I admit I havn't spent a lot of time thinking
yet, but off the cuff :
1. We should drop PayloadSpans and just add getPayload to Spans. This should be
a compile time break.
2. We need a way to *not* collect payloads. Now they will be collected if they
are there whether they are used or not. Perhaps an argument in the SpanQuery
constructor? It can't really be getSpans because the user would need to control
it.
> getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
> ------------------------------------------------------------------------------
>
> Key: LUCENE-1748
> URL: https://issues.apache.org/jira/browse/LUCENE-1748
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 2.4, 2.4.1
> Environment: all
> Reporter: Hugh Cayless
> Fix For: 2.9, 3.0, 3.1
>
>
> I just spent a long time tracking down a bug resulting from upgrading to
> Lucene 2.4.1 on a project that implements some SpanQuerys of its own and was
> written against 2.3. Since the project's SpanQuerys didn't implement
> getPayloadSpans, the call to that method went to SpanQuery.getPayloadSpans
> which returned null and caused a NullPointerException in the Lucene code, far
> away from the actual source of the problem.
> It would be much better for this kind of thing to show up at compile time, I
> think.
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
