[
https://issues.apache.org/jira/browse/LUCENE-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738714#action_12738714
]
Mark Miller commented on LUCENE-1748:
-------------------------------------
Has something like this come up in the past? How was the back compat branch
handled? Should I just remove the PayloadSpans test? It doesn't seem right to
apply the patch to the back compat src - it wouldn't apply cleanly anyway, and
it doesn't seem right to fit it in. I guess it may not matter though? I'm just
worried it will be like pulling a string ...
the issue:
The PayloadSpans test was made to test PayloadSpans - but that class shouldn't
have been made and the methods from it have been added to Spans, and its been
removed. Now the back compat branch test won't compile against the back compat
src.
> getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
> ------------------------------------------------------------------------------
>
> Key: LUCENE-1748
> URL: https://issues.apache.org/jira/browse/LUCENE-1748
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 2.4, 2.4.1
> Environment: all
> Reporter: Hugh Cayless
> Assignee: Mark Miller
> Fix For: 2.9, 3.0, 3.1
>
> Attachments: LUCENE-1748.patch, LUCENE-1748.patch
>
>
> I just spent a long time tracking down a bug resulting from upgrading to
> Lucene 2.4.1 on a project that implements some SpanQuerys of its own and was
> written against 2.3. Since the project's SpanQuerys didn't implement
> getPayloadSpans, the call to that method went to SpanQuery.getPayloadSpans
> which returned null and caused a NullPointerException in the Lucene code, far
> away from the actual source of the problem.
> It would be much better for this kind of thing to show up at compile time, I
> think.
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
