[
https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1754:
-------------------------------
Attachment: LUCENE-1754.patch
Patch which removes NonMatchingScorer, fixes tests and tag.
I also agree this is not a back-compat change, since BooleanQuery returns null
today already. I just fixed the test to check whether the scorer returned is
not null.
I don't think we should return NonMatchingScorer from QueryWeightWrapper, since
it will hide the already returned null Scorer. I.e., I think that will cause
some apps to break, since if previously they relied on null, now they will get
an instance which if they'll call its score() or doc() methods will get UOE.
> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>
> Key: LUCENE-1754
> URL: https://issues.apache.org/jira/browse/LUCENE-1754
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Shai Erera
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1754.patch
>
>
> Over in Lucene-1614 Mike has made a comment about removing NonMatchinScorer
> from BS2, and return null in BooleanWeight.scorer(). I've checked and this
> can be easily done, so I'm going to post a patch shortly. For reference:
> https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064.
> I've marked the issue as 2.9 just because it's small, and kind of related to
> all the search enhancements done for 2.9.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
