[ https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733213#action_12733213 ]
Shai Erera commented on LUCENE-1754: ------------------------------------ bq. See ConstantScoreQuery.explain() for instance. CSQ calls its own scorer(), therefore it knows it's going to get an instance back. In general, BooleanQuery already returns null today, so all I was saying is that if someone called BQ.weight.scorer(), he had to check for null anyway. If he didn't then his app would be exposed? > Get rid of NonMatchingScorer from BooleanScorer2 > ------------------------------------------------ > > Key: LUCENE-1754 > URL: https://issues.apache.org/jira/browse/LUCENE-1754 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Reporter: Shai Erera > Priority: Minor > Fix For: 2.9 > > Attachments: LUCENE-1754.patch > > > Over in LUCENE-1614 Mike has made a comment about removing NonMatchinScorer > from BS2, and return null in BooleanWeight.scorer(). I've checked and this > can be easily done, so I'm going to post a patch shortly. For reference: > https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064. > I've marked the issue as 2.9 just because it's small, and kind of related to > all the search enhancements done for 2.9. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org