[
https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733759#action_12733759
]
Shai Erera commented on LUCENE-1754:
------------------------------------
bq. hence one would get a cast exception if "return null" were blindly replaced
with "return NMS".
So this means that that someone is prepared to get a null Scorer right? So I'm
confused - are you for returning null or not? Of course, something I just
realized, returning null from scorer() does not break back-compat, while
returning NMS does (or at least may).
How about if we fix QueryWrapperFilter to return NMS then? Or we document that
Filter.getDocIdSet may return null, and fix IndexSearcher accordingly (this
again is not a back-compat thing, while returning NMS is)?
> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>
> Key: LUCENE-1754
> URL: https://issues.apache.org/jira/browse/LUCENE-1754
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1754.patch
>
>
> Over in LUCENE-1614 Mike has made a comment about removing NonMatchinScorer
> from BS2, and return null in BooleanWeight.scorer(). I've checked and this
> can be easily done, so I'm going to post a patch shortly. For reference:
> https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064.
> I've marked the issue as 2.9 just because it's small, and kind of related to
> all the search enhancements done for 2.9.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
