[
https://issues.apache.org/jira/browse/LUCENE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eks Dev updated LUCENE-1762:
----------------------------
Attachment: LUCENE-1762.patch
made the changes in Token along the same lines,
- had to change one constant in TokenTest as I have changed initial allocation
policy of termBuffer to be consistent with Arayutils.getnextSize()
if(termBuffer==null)
NEW:
termBuffer = new char[ArrayUtil.getNextSize(newSize < MIN_BUFFER_SIZE ?
MIN_BUFFER_SIZE : newSize)];
OLD:
termBuffer = new char[newSize < MIN_BUFFER_SIZE ? MIN_BUFFER_SIZE : newSize];
not sure if this is better, but looks more consistent to me (buffer size is
always determined via getNewSize())
Uwe,
setOnlyUseNewAPI(false) does not exist, it was removed with some of the patches
lately. It gets automatically detected via reflection?
> Slightly more readable code in TermAttributeImpl
> -------------------------------------------------
>
> Key: LUCENE-1762
> URL: https://issues.apache.org/jira/browse/LUCENE-1762
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Eks Dev
> Assignee: Uwe Schindler
> Priority: Trivial
> Attachments: LUCENE-1762.patch, LUCENE-1762.patch
>
>
> No big deal.
> growTermBuffer(int newSize) was using correct, but slightly hard to follow
> code.
> the method was returning null as a hint that the current termBuffer has
> enough space to the upstream code or reallocated buffer.
> this patch simplifies logic making this method to only reallocate buffer,
> nothing more.
> It reduces number of if(null) checks in a few methods and reduces amount of
> code.
> all tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
