[
https://issues.apache.org/jira/browse/LUCENE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735796#action_12735796
]
Uwe Schindler edited comment on LUCENE-1762 at 7/27/09 2:56 PM:
----------------------------------------------------------------
Extended patch. It adds also tests for the basic attributes (in trunk only
token was tested). The new tests check every impls basic functionality and
clone/copyTo. It also contains the buffer tests of Token for TermAttribute.
To apply the patch you must first do a:
{code}
svn copy src/test/org/apache/lucene/analysis/TestToken.java
src/test/org/apache/lucene/analysis/tokenattributes/TestTermAttributeImpl.java
{code}
It also modified the AttributeImpls default toString() to only print instance
fields, not static fields.
was (Author: thetaphi):
Extended patch. It adds also tests for the basic attributes (in trunk only
token was tested). The new tests check every impls basic functionality and
clone/copyTo. It also contains the buffer tests of Token for TermAttribute.
To apply the patch you must first do a:
{code}
svn copy src/test/org/apache/lucene/analysis/Token.java
src/test/org/apache/lucene/analysis/tokenattributes/TestTermAttributeImpl.java
{code}
It also modified the AttributeImpls default toString() to only print instance
fields, not static fields.
> Slightly more readable code in TermAttributeImpl
> -------------------------------------------------
>
> Key: LUCENE-1762
> URL: https://issues.apache.org/jira/browse/LUCENE-1762
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Affects Versions: 2.9
> Reporter: Eks Dev
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1762.patch, LUCENE-1762.patch, LUCENE-1762.patch,
> LUCENE-1762.patch
>
>
> No big deal.
> growTermBuffer(int newSize) was using correct, but slightly hard to follow
> code.
> the method was returning null as a hint that the current termBuffer has
> enough space to the upstream code or reallocated buffer.
> this patch simplifies logic making this method to only reallocate buffer,
> nothing more.
> It reduces number of if(null) checks in a few methods and reduces amount of
> code.
> all tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
