[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736114#action_12736114 ]
Uwe Schindler commented on LUCENE-1695: --------------------------------------- bq. not to hijack this issue (sorry) but Uwe, this reminds me that there are things that extend SinkTokenizer in contrib (analysis/sinks) as well, so it would be great to have a migration plan for those also Extend!? Very bad, all TokenStreams should be final :-) -- *should be* but may not. I think these classes should stay as they are and use Tee/Sink and we should deprecate them. But TeeSinkTokenStream is final (and this is important) and the corresponding Sinks are somehow abstract (without "known" implementation). > Update the Highlighter to use the new TokenStream API > ----------------------------------------------------- > > Key: LUCENE-1695 > URL: https://issues.apache.org/jira/browse/LUCENE-1695 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/highlighter > Reporter: Mark Miller > Assignee: Mark Miller > Fix For: 2.9 > > Attachments: LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch, > LUCENE-1695.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org