[
https://issues.apache.org/jira/browse/LUCENE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737366#action_12737366
]
Nick Pellow edited comment on LUCENE-1769 at 7/30/09 4:59 PM:
--------------------------------------------------------------
HI Uwe,
Great work getting Clover upgraded. I've also done an upgrade, although have
some test failures on my local machine. I am pretty sure these are not caused
by Clover, however would love for you to double check.
Clover 2 does not require the clover.jar to be installed into an Ant Lib, so I
suggest checking it in trunk/lib/ , right next to junit.jar .
We will be generating a new site license for org.apache that can also be
committed to your public svn server, so anyone wanting to develop on Lucene can
just use Clover out of the box, on their desktop.
Some other things I did was to change the fileset in the clover-setup task to:
{code}
<fileset dir="src">
<!-- see https://issues.apache.org/jira/browse/LUCENE-1772 -->
<include name="**/org/apache/**"/>
<include name="**/lucli/**"/>
<include name="**/com/example/**"/>
<exclude
name="**/org/apache/lucene/analysis/TestASCIIFoldingFilter.java"/> <!-- Illegal
char on line 190-->
</fileset>
{code}
This means that all of the src and test java files in contrib will also be
instrumented by clover, if that is what you want?
I also removed the clover.enabled property, since clover should always be
available from now on.
I added the <testsources/> element to both the HTML and the XML report tasks
too. This ensures that the coverage of your test cases themselves are reported
in a seperate section of each report.
I would also suggest we remove the clover.run property. Simply calling the
'clover' target at the start of the build will be enough to have clover
swtiched on for the build.
Other than that, I've tried to leave things as they were.
Please let me know if you have any questions, or problems!
The 2.4.3 license will work - we will have a site license available next week.
Cheers,
Nick
was (Author: npellow):
HI Uwe,
Great work getting Clover upgraded. I've also done an upgrade, although have
some test failures on my local machine. I am pretty sure these are not caused
by Clover, however would love for you to double check.
Clover 2 does not require the clover.jar to be installed into an Ant Lib, so I
suggest checking it in trunk/lib/ , right next to junit.jar .
We will be generating a new site license for org.apache that can also be
committed to your public svn server, so anyone wanting to develop on Lucene can
just use Clover out of the box, on their desktop.
Some other things I did was to change the fileset in the clover-setup task to:
{code}
<fileset dir="src">
<!-- see https://issues.apache.org/jira/browse/LUCENE-1772 -->
<include name="**/org/apache/**"/>
<include name="**/lucli/**"/>
<include name="**/com/example/**"/>
<exclude
name="**/org/apache/lucene/analysis/TestASCIIFoldingFilter.java"/> <!-- Illegal
char on line 190-->
</fileset>
{code}
This means that all of the src and test java files in contrib will also be
instrumented by clover, if that is what you want?
I also removed the clover.enabled property, since clover should always be
available from now on.
I added the <testsources/> element to both the HTML and the XML report tasks
too. This ensures that the coverage of your test cases themselves are reported
in a seperate section of each report.
Other than that, I've tried to leave things as they were.
Please let me know if you have any questions, or problems!
The 2.4.3 license will work - we will have a site license available next week.
Cheers,
Nick
> Fix wrong clover analysis because of backwards-tests, upgrade clover to 2.4.3
> or better
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1769
> URL: https://issues.apache.org/jira/browse/LUCENE-1769
> Project: Lucene - Java
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Attachments: LUCENE-1769.patch
>
>
> This is a followup for
> [http://www.lucidimagination.com/search/document/6248d6eafbe10ef4/build_failed_in_hudson_lucene_trunk_902]
> The problem with clover running on hudson is, that it does not instrument all
> tests ran. The autodetection of clover 1.x is not able to find out which
> files are the correct tests and only instruments the backwards test. Because
> of this, the current coverage report is only from the backwards tests running
> against the current Lucene JAR.
> You can see this, if you install clover and start the tests. During test-core
> no clover data is added to the db, only when backwards-tests begin, new files
> are created in the clover db folder.
> Clover 2.x supports a new ant task, <testsources> that can be used to specify
> the files, that are the tests. It works here locally with clover 2.4.3 and
> produces a really nice coverage report, also linking with test files work, it
> tells which tests failed and so on.
> I will attach a patch, that changes common-build.xml to the new clover
> version (other initialization resource) and tells clover where to find the
> tests (using the test folder include/exclude properties).
> One problem with the current patch: It does *not* instrument the backwards
> branch, so you see only coverage of the core/contrib tests. Getting the
> coverage also from the backwards tests is not easy possible because of two
> things:
> - the tag test dir is not easy to find out and add to <testsources> element
> (there may be only one of them)
> - the test names in BW branch are identical to the trunk tests. This
> completely corrupts the linkage between tests and code in the coverage report.
> In principle the best would be to generate a second coverage report for the
> backwards branch with a separate clover DB. The attached patch does not
> instrument the bw branch, it only does trunk tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
