[
https://issues.apache.org/jira/browse/LUCENE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737481#action_12737481
]
Nick Pellow commented on LUCENE-1769:
-------------------------------------
bq. Thanks for all your help!
And thanks for all yours by making Lucene!
re: <clover-setup><testsources/>..
OK - I was not aware of the backwards-branch tests.
As long as the right tests are being instrumented Clover, and correctly
detected as tests, then all should be good.
bq. The problem with that is, that we then have clover.jar inside the source
distribution, which adds 9 MB of extra stuff.
I see. I didn't realise that the lib dir gets included into the source
distribution. Is there another directory in svn, other than lib, that the
clover.jar could live and not get included into the source distro? Or is the
source distro just an archive of the entire trunk directory?
bq. And from the legal standpoint, I am not sure, if it is ok to bundle a
non-free product together with Apache licensed software
Yep - not a good idea to bundle with Lucene, but it is fine to have it checked
into your version control.
bq. I would like to have the clover.jar outside of the Lucene source distrib as
before
Whatever you think will work best - I was just thinking that the clover.jar was
not checked into svn within lucene because of the old Ant Lib requirement of
clover1.
bq. What tests are failing for you? Normally all should pass at the moment (see
build logs at Apache's Hudson).
One of the XML tests was failing. I was only running :
{code}
ant clover test -Drun.clover
{code}
so thought this may have been an environment flag or target I was missing.
Anyway, please let me know if you have any more questions regarding Clover2.
Cheers,
Nick
> Fix wrong clover analysis because of backwards-tests, upgrade clover to 2.4.3
> or better
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1769
> URL: https://issues.apache.org/jira/browse/LUCENE-1769
> Project: Lucene - Java
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Attachments: LUCENE-1769.patch, LUCENE-1769.patch,
> nicks-LUCENE-1769.patch
>
>
> This is a followup for
> [http://www.lucidimagination.com/search/document/6248d6eafbe10ef4/build_failed_in_hudson_lucene_trunk_902]
> The problem with clover running on hudson is, that it does not instrument all
> tests ran. The autodetection of clover 1.x is not able to find out which
> files are the correct tests and only instruments the backwards test. Because
> of this, the current coverage report is only from the backwards tests running
> against the current Lucene JAR.
> You can see this, if you install clover and start the tests. During test-core
> no clover data is added to the db, only when backwards-tests begin, new files
> are created in the clover db folder.
> Clover 2.x supports a new ant task, <testsources> that can be used to specify
> the files, that are the tests. It works here locally with clover 2.4.3 and
> produces a really nice coverage report, also linking with test files work, it
> tells which tests failed and so on.
> I will attach a patch, that changes common-build.xml to the new clover
> version (other initialization resource) and tells clover where to find the
> tests (using the test folder include/exclude properties).
> One problem with the current patch: It does *not* instrument the backwards
> branch, so you see only coverage of the core/contrib tests. Getting the
> coverage also from the backwards tests is not easy possible because of two
> things:
> - the tag test dir is not easy to find out and add to <testsources> element
> (there may be only one of them)
> - the test names in BW branch are identical to the trunk tests. This
> completely corrupts the linkage between tests and code in the coverage report.
> In principle the best would be to generate a second coverage report for the
> backwards branch with a separate clover DB. The attached patch does not
> instrument the bw branch, it only does trunk tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
